public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
To: Rusty Lynch <rusty.lynch@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [ia64][patch] Refuse inserting kprobe on slot 1
Date: Thu, 23 Jun 2005 23:43:51 +0000	[thread overview]
Message-ID: <20050623164351.A26121@unix-os.sc.intel.com> (raw)
In-Reply-To: <200506230232.j5N2WgwS018522@linux.jf.intel.com>; from rusty.lynch@intel.com on Wed, Jun 22, 2005 at 07:32:42PM -0700

On Wed, Jun 22, 2005 at 07:32:42PM -0700, Rusty Lynch wrote:
> 
>    +
>    +       if (slot = 1) {
Rusty, this is wrong. You should fail only
	if (slot = 1) && (bundle_encoding[template][1] != L) {
This is because for MLX template we will actually be patching
the instruction on slot = 2 and not on slot 1.
>    +               printk(KERN_WARNING "Inserting kprobes on slot #1 "
>    +                      "is not supported\n");
>    +               return -EINVAL;
>    +       }
>    +
>            return 0;
>     }
> 

-Anil

      reply	other threads:[~2005-06-23 23:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-23  2:32 [ia64][patch] Refuse inserting kprobe on slot 1 Rusty Lynch
2005-06-23 23:43 ` Keshavamurthy Anil S [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050623164351.A26121@unix-os.sc.intel.com \
    --to=anil.s.keshavamurthy@intel.com \
    --cc=akpm@osdl.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty.lynch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox