From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: "Martin J. Bligh" <mbligh@mbligh.org>
Cc: linux-mm <linux-mm@kvack.org>, "Luck, Tony" <tony.luck@intel.com>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] gurantee DMA area for alloc_bootmem_low()
Date: Wed, 13 Jul 2005 05:09:19 +0000 [thread overview]
Message-ID: <20050713110109.F796.Y-GOTO@jp.fujitsu.com> (raw)
In-Reply-To: <9320000.1121179193@[10.10.2.4]>
> > To avoid this panic, following patch skips no DMA'ble node when
> > lower address is required.
> > I tested this patch on my Tiger 4 and our new server.
>
> Seems reasonable ... but do you not want to check that the returned
> ptr is actually less than MAX_DMA_ADDRESS as well?
Well... If there isn't enough DMA area in a node by too much
lower memory request or by something strange memory map in the node,
its case might occur.
I don't know it will really happen. But, the after check might be better
than nothing.
To tell the truth, I did the after check at first
"instead of" previous check like this patch.
In its patch, if its DMA check failed,
allocated area are should be freed by free_bootmem_core().
But hung up occurred by it, and I changed my patch to previous check
instead of deep investigation of its hung up.
Ok. I'll investigate more.
Thanks.
--
Yasunori Goto
next prev parent reply other threads:[~2005-07-13 5:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-12 6:50 [PATCH] gurantee DMA area for alloc_bootmem_low() Yasunori Goto
2005-07-12 14:39 ` Martin J. Bligh
2005-07-13 5:09 ` Yasunori Goto [this message]
2005-07-12 18:30 ` Mike Kravetz
2005-07-12 19:29 ` Dave Hansen
2005-07-12 20:37 ` Mike Kravetz
2005-07-13 6:34 ` Yasunori Goto
2005-07-13 22:03 ` Mike Kravetz
2005-07-15 2:43 ` Yasunori Goto
2005-08-09 11:11 ` [PATCH] gurantee DMA area for alloc_bootmem_low() ver. 2 Yasunori Goto
2005-08-09 15:05 ` Martin J. Bligh
2005-08-09 21:15 ` Mike Kravetz
2005-08-10 3:06 ` Dave Hansen
2005-08-10 16:23 ` Dave Hansen
2005-08-11 20:46 ` Christoph Lameter
2005-08-11 21:14 ` Mike Kravetz
2005-08-11 22:37 ` Christoph Lameter
2005-08-09 23:02 ` Peter Chubb
2005-08-10 6:10 ` Yasunori Goto
2005-08-18 19:52 ` Andrew Morton
2005-08-18 21:39 ` Andi Kleen
2005-08-19 2:29 ` Yasunori Goto
2005-08-19 3:03 ` Andi Kleen
2005-08-19 1:26 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050713110109.F796.Y-GOTO@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@mbligh.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox