From: Andi Kleen <ak@suse.de>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Fix gcc 4 warnings on ia64
Date: Tue, 16 Aug 2005 23:34:39 +0000 [thread overview]
Message-ID: <20050816233439.GR20749@wotan.suse.de> (raw)
In-Reply-To: <20050816155747.GN20749@wotan.suse.de>
On Wed, Aug 17, 2005 at 09:04:24AM +1000, Peter Chubb wrote:
> >>>>> "Andi" = Andi Kleen <ak@suse.de> writes:
>
> Andi> I was compiling an IA64 2.6.13rc6 kernel on a machine with gcc 4
> Andi> to test something. The compile spew a incredibly large number of
> Andi> warnings. This patch fixes the most annoying ones from commonly
> Andi> included makefiles. In these two cases gcc was complaining that
> Andi> functions cannot be volatile or const.
>
> You actually need the const attribute on __ia64_get_io_port_base ---
> see the thread at
> http://www.gelato.unsw.edu.au/archives/linux-ia64/0507/14658.html
Ian is wrong here. const never did the same thing as __attribute__((const))
And for an inline __attribute__((const)) is a nop because the compiler
always looks at the code inside the inline and decides based
on that if the return value is constant or not.
-Andi
next prev parent reply other threads:[~2005-08-16 23:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-16 15:57 [PATCH] Fix gcc 4 warnings on ia64 Andi Kleen
2005-08-16 23:04 ` Peter Chubb
2005-08-16 23:34 ` Andi Kleen [this message]
2005-08-17 0:05 ` Luck, Tony
2005-08-17 0:11 ` Andi Kleen
2005-08-17 1:30 ` david mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050816233439.GR20749@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox