public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: paulus@samba.org, Andrew Morton <akpm@osdl.org>
Cc: nickpiggin@yahoo.com.au, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org, torvalds@osdl.org, mingo@elte.hu,
	hawkes@sgi.com, Paul Jackson <pj@sgi.com>,
	dino@in.ibm.com
Subject: [PATCH 2.6.13-rc6] cpu_exclusive sched domains build fix
Date: Wed, 24 Aug 2005 11:15:10 +0000	[thread overview]
Message-ID: <20050824111510.11478.49764.sendpatchset@jackhammer.engr.sgi.com> (raw)
In-Reply-To: <20050823080427.14740.20177.sendpatchset@jackhammer.engr.sgi.com>

As reported by Paul Mackerras <paulus@samba.org>, the previous
patch "cpu_exclusive sched domains fix" broke the ppc64 build,
yielding error messages:

kernel/cpuset.c: In function 'update_cpu_domains':
kernel/cpuset.c:648: error: invalid lvalue in unary '&'
kernel/cpuset.c:648: error: invalid lvalue in unary '&'

On some arch's, the node_to_cpumask() is a function, returning
a cpumask_t.  But the for_each_cpu_mask() requires an lvalue mask.

The following patch fixes this build failure by making a copy
of the cpumask_t on the stack.

I have _not_ yet tried to build this for ppc64 - just for ia64.
I will try that now.  But the fix seems obvious enough that it
is worth sending out now.

Signed-off-by: Paul Jackson <pj@sgi.com>

Index: linux-2.6.13-cpuset-mempolicy-migrate/kernel/cpuset.c
=================================--- linux-2.6.13-cpuset-mempolicy-migrate.orig/kernel/cpuset.c
+++ linux-2.6.13-cpuset-mempolicy-migrate/kernel/cpuset.c
@@ -645,7 +645,9 @@ static void update_cpu_domains(struct cp
 		int i, j;
 
 		for_each_cpu_mask(i, cur->cpus_allowed) {
-			for_each_cpu_mask(j, node_to_cpumask(cpu_to_node(i))) {
+			cpumask_t mask = node_to_cpumask(cpu_to_node(i));
+
+			for_each_cpu_mask(j, mask) {
 				if (!cpu_isset(j, cur->cpus_allowed))
 					return;
 			}

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373

  parent reply	other threads:[~2005-08-24 11:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-23  8:04 [PATCH 2.6.13-rc6] cpu_exclusive sched domains on partial nodes temp fix Paul Jackson
2005-08-23  8:10 ` Ingo Molnar
2005-08-23 15:19 ` Dinakar Guniguntala
2005-08-24  0:19 ` John Hawkes
2005-08-24 11:15 ` Paul Jackson [this message]
2005-08-24 11:38   ` [PATCH 2.6.13-rc6] cpu_exclusive sched domains build fix Dinakar Guniguntala
2005-08-24 11:46     ` Paul Jackson
2005-08-24 12:01       ` Nick Piggin
2005-08-24 20:31         ` Paul Jackson
2005-08-25  0:02           ` Nick Piggin
2005-08-25  0:57             ` Paul Jackson
2005-08-25 14:53           ` Dinakar Guniguntala
2005-08-25 15:20             ` Paul Jackson
2005-08-24 16:09     ` John Hawkes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050824111510.11478.49764.sendpatchset@jackhammer.engr.sgi.com \
    --to=pj@sgi.com \
    --cc=akpm@osdl.org \
    --cc=dino@in.ibm.com \
    --cc=hawkes@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    --cc=paulus@samba.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox