Re: [PATCH 2.6.13-rc6] cpu_exclusive sched domains on partial nodes temp fix

Ingo Molnar
2005-08-23T08:10:35Z

* Paul Jackson <pj@sgi.com> wrote:

> /*
> + * Hack to avoid 2.6.13 partial node dynamic sched domain bug.
> + * Require the 'cpu_exclusive' cpuset to include all (or none)
> + * of the CPUs on each node, or return w/o changing sched domains.
> + * Remove this hack when dynamic sched domains fixed.
> + */
> + {
> + int i, j;
> +
> + for_each_cpu_mask(i, cur->cpus_allowed) {
> + for_each_cpu_mask(j, node_to_cpumask(cpu_to_node(i))) {
> + if (!cpu_isset(j, cur->cpus_allowed))
> + return;
> + }
> + }
> + }
> +

certainly looks acceptable from a scheduler POV.

Acked-by: Ingo Molnar <mingo@elte.hu>

Ingo