Re: [PATCH 2.6.13-rc6] cpu_exclusive sched domains build fix

Dinakar Guniguntala
2005-08-24T11:38:40Z

Paul,

Can we hold on to this patch for a while, as I reported yesterday,
this hangs up my ppc64 box on doing rmdir on a exclusive cpuset.
Still debugging the problem, hope to have a fix soon, Thanks

-Dinakar

On Wed, Aug 24, 2005 at 04:15:10AM -0700, Paul Jackson wrote:
> As reported by Paul Mackerras <paulus@samba.org>, the previous
> patch "cpu_exclusive sched domains fix" broke the ppc64 build,
> yielding error messages:
>
> kernel/cpuset.c: In function 'update_cpu_domains':
> kernel/cpuset.c:648: error: invalid lvalue in unary '&'
> kernel/cpuset.c:648: error: invalid lvalue in unary '&'
>
> On some arch's, the node_to_cpumask() is a function, returning
> a cpumask_t. But the for_each_cpu_mask() requires an lvalue mask.
>
> The following patch fixes this build failure by making a copy
> of the cpumask_t on the stack.
>
> I have _not_ yet tried to build this for ppc64 - just for ia64.
> I will try that now. But the fix seems obvious enough that it
> is worth sending out now.
>
> Signed-off-by: Paul Jackson <pj@sgi.com>
>
> Index: linux-2.6.13-cpuset-mempolicy-migrate/kernel/cpuset.c
> =================================> --- linux-2.6.13-cpuset-mempolicy-migrate.orig/kernel/cpuset.c
> +++ linux-2.6.13-cpuset-mempolicy-migrate/kernel/cpuset.c
> @@ -645,7 +645,9 @@ static void update_cpu_domains(struct cp
> int i, j;
>
> for_each_cpu_mask(i, cur->cpus_allowed) {
> - for_each_cpu_mask(j, node_to_cpumask(cpu_to_node(i))) {
> + cpumask_t mask = node_to_cpumask(cpu_to_node(i));
> +
> + for_each_cpu_mask(j, mask) {
> if (!cpu_isset(j, cur->cpus_allowed))
> return;
> }
>
> --
> I won't rest till it's the best ...
> Programmer, Linux Scalability
> Paul Jackson <pj@sgi.com> 1.650.933.1373
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>