From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: linux-ia64@vger.kernel.org
Subject: [patch] delete sync.i in ia64_switch_to()
Date: Wed, 07 Sep 2005 07:22:29 +0000 [thread overview]
Message-ID: <200509070723.j877N9g25144@unix-os.sc.intel.com> (raw)
The sync.i instruction in ia64_switch_to() context switch code
looks like an old leftover code. sync.i instruction supposedly
ensures flush cache operation issued by processor become visible
to memory reference. Everywhere I looked where fc instruction is
used (ia64_fc), a sync.i is always accompanied. Everywhere in
the vicinity of context switch (save_switch_stack/load_switch_stack)
don't have any fc instruction in there. I don't see any reason why
we need to issue sync.i in context switch code. Patch to remove it.
Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
--- ./arch/ia64/kernel/entry.S.orig 2005-09-06 22:36:17.114182129 -0700
+++ ./arch/ia64/kernel/entry.S 2005-09-07 00:20:37.216644505 -0700
@@ -213,10 +213,6 @@ GLOBAL_ENTRY(ia64_switch_to)
mov r13=in0 // set "current" pointer
;;
DO_LOAD_SWITCH_STACK
-
-#ifdef CONFIG_SMP
- sync.i // ensure "fc"s done by this CPU are visible on other CPUs
-#endif
br.ret.sptk.many rp // boogie on out in new context
.map:
next reply other threads:[~2005-09-07 7:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-07 7:22 Chen, Kenneth W [this message]
2005-09-07 8:00 ` [patch] delete sync.i in ia64_switch_to() Chen, Kenneth W
2005-09-07 17:33 ` Jim Hull
2005-09-07 17:59 ` david mosberger
2005-09-07 19:12 ` Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509070723.j877N9g25144@unix-os.sc.intel.com \
--to=kenneth.w.chen@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox