public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: linux-ia64@vger.kernel.org
Subject: Re: Remove warnings for gcc 4.0 IA64 compilation.
Date: Fri, 16 Sep 2005 16:42:14 +0000	[thread overview]
Message-ID: <20050916164214.GA9285@agluck-lia64.sc.intel.com> (raw)
In-Reply-To: <17193.2147.591751.129603@berry.gelato.unsw.EDU.AU>

On Thu, Sep 15, 2005 at 03:36:35PM +1000, Peter Chubb wrote:
> Index: linux-2.6-import/arch/ia64/kernel/time.c
> -	printk(KERN_DEBUG "CPU %d: base freq=%lu.%03luMHz, ITC ratio=%lu/%lu, "
> +	printk(KERN_DEBUG "CPU %d: base freq=%lu.%03luMHz, ITC ratio=%u/%u, "
>  	       "ITC freq=%lu.%03luMHz", smp_processor_id(),
>  	       platform_base_freq / 1000000, (platform_base_freq / 1000) % 1000,
>  	       itc_ratio.num, itc_ratio.den, itc_freq / 1000000, (itc_freq / 1000) % 1000);

This hunk is surely wrong?  itc_freq is unsigned long, so itc_freq/1000000
still has unsigned long type.

The other pieces all look good.

-Tony

  reply	other threads:[~2005-09-16 16:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-15  5:36 Remove warnings for gcc 4.0 IA64 compilation Peter Chubb
2005-09-16 16:42 ` Luck, Tony [this message]
2005-09-18 23:10 ` Peter Chubb
2005-09-19  6:51 ` Tony Luck
2005-09-19 16:43 ` Luck, Tony
2005-09-19 17:46 ` David Mosberger-Tang
2005-09-19 18:58 ` James E Wilson
2005-09-19 19:05 ` David Mosberger-Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050916164214.GA9285@agluck-lia64.sc.intel.com \
    --to=tony.luck@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox