Re: [Lhms-devel] [PATCH 4/4] V4 ia64 SPARSEMEM - SPARSEMEM code changes

Matthew Wilcox
2005-09-22T17:13:40Z

On Thu, Sep 22, 2005 at 09:36:16AM -0700, Dave Hansen wrote:
> >
> > - return (i < num_node_memblks) ? node_memblk[i].nid : (num_node_memblks ? -1 : 0);
> > + return (i < num_node_memblks) ?
> > + node_memblk[i].nid : (num_node_memblks ? -1 : 0);
> > }
>
> Looks like just a whitespace change.

But really far less radical than it deserves ... nested conditional
expressions? Come on. How about:

if (i < num_node_memblks)
return node_memblk[i].nid;
if (num_node_memblks)
return -1;
return 0;