public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Bob Picco <bob.picco@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Lhms-devel] [PATCH 4/4] V4 ia64 SPARSEMEM - SPARSEMEM code changes
Date: Thu, 22 Sep 2005 18:47:23 +0000	[thread overview]
Message-ID: <20050922184723.GE16066@localhost.localdomain> (raw)
In-Reply-To: <1127406976.10664.52.camel@localhost>

Dave Hansen wrote:	[Thu Sep 22 2005, 02:05:07PM EDT]
> On Thu, 2005-09-22 at 13:59 -0400, Bob Picco wrote:
> > > > +#ifdef CONFIG_VIRTUAL_MEM_MAP
> > > >             NODE_DATA(node)->node_mem_map = vmem_map + pfn_offset;
> > > > +#endif
> > > 
> > > Is CONFIG_FLAT_NODE_MEM_MAP more appropriate here?  That's how
> > > ->node_mem_map is #ifdef'd to begin with in mmzone.h.
> >
> > Well I think this is doable but probaably shouldn't. This code is very
> > specific to CONFIG_VIRTUAL_MEM_MAP.
> 
> FLAT_NODE_MEM_MAP depends on only !SPARSEMEM, as does VIRTUAL_MEM_MAP.
> So, I guess they're functionally equivalent right now.  It might be most
> nice to at least add a comment, saying that it actually depends on both.
> 
> 
> 
> -- Dave
> 
Okay. I'll add a comment before VIRTUAL_MEM_MAP in Kconfig file. That will
cover all uses of VIRTUAL_MEM_MAP.

thanks,

bob

      parent reply	other threads:[~2005-09-22 18:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-22 16:36 [Lhms-devel] [PATCH 4/4] V4 ia64 SPARSEMEM - SPARSEMEM code Dave Hansen
2005-09-22 17:13 ` [Lhms-devel] [PATCH 4/4] V4 ia64 SPARSEMEM - SPARSEMEM code changes Matthew Wilcox
2005-09-22 17:59 ` Bob Picco
2005-09-22 18:01 ` Bob Picco
2005-09-22 18:05 ` [Lhms-devel] [PATCH 4/4] V4 ia64 SPARSEMEM - SPARSEMEM code Dave Hansen
2005-09-22 18:47 ` Bob Picco [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050922184723.GE16066@localhost.localdomain \
    --to=bob.picco@hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox