Re: [patch 2.6.13 4/6] swiotlb: support syncing DMA_BIDIRECTIONAL mappings

John W. Linville
2005-09-12T19:51:12Z

On Mon, Sep 12, 2005 at 11:51:20AM -0700, Grant Grundler wrote:
> On Mon, Sep 12, 2005 at 10:48:51AM -0400, John W. Linville wrote:

> > + case SYNC_FOR_DEVICE:
> > + if (likely(dir = DMA_TO_DEVICE || dir = DMA_BIDIRECTIONAL))
> > + memcpy(dma_addr, buffer, size);
> > + else if (dir != DMA_FROM_DEVICE && dir != DMA_NONE)
> > + BUG();
> > + break;
> > + default:

> Isn't "DMA_NONE" expected to generate a warning or panic?

True enough...I'll follow-up w/ an additive patch to account for that.
As you pointed-out, the higher-level functions in swiotlb filter that
out anyway, so this really isn't a big issue.

John
--
John W. Linville
linville@tuxdriver.com