From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Edwards Date: Wed, 28 Sep 2005 22:05:19 +0000 Subject: Re: [Lhms-devel] RE: [PATCH 0/4] V4 ia64 SPARSEMEM Message-Id: <20050928220518.GL14436@sgi.com> List-Id: References: <1127779977.10315.6.camel@localhost> In-Reply-To: <1127779977.10315.6.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-ia64@vger.kernel.org On Wed, Sep 28, 2005 at 11:42:44AM -0400, Bob Picco wrote: | I had a problem booting sparsemem_defconfig without modules on my rx2600. | After removing CONFIG_SGI_MBCS it booted fine. |=20 | Badness in kref_get at lib/kref.c:32 |=20 | Call Trace: | [] show_stack+0x80/0xa0 | sp=E000000003177c10 bsp=E000000003170fd0 | [] dump_stack+0x30/0x60 | sp=E000000003177de0 bsp=E000000003170fb8 | [] kref_get+0xa0/0xc0 | sp=E000000003177de0 bsp=E000000003170f98 | [] kobject_get+0x30/0x60 | sp=E000000003177de0 bsp=E000000003170f78 | [] get_bus+0x40/0xa0 | sp=E000000003177de0 bsp=E000000003170f58 | [] bus_add_driver+0x30/0x180 | sp=E000000003177de0 bsp=E000000003170f20 | [] driver_register+0x70/0xa0 | sp=E000000003177de0 bsp=E000000003170f00 | [] cx_driver_register+0x70/0xa0 | sp=E000000003177de0 bsp=E000000003170ee0 | [] mbcs_init+0x80/0xc0 | sp=E000000003177de0 bsp=E000000003170ec0 | [] do_initcalls+0xb0/0x200 | sp=E000000003177de0 bsp=E000000003170e58 | [] do_basic_setup+0x70/0xa0 | sp=E000000003177de0 bsp=E000000003170e40 | [] init+0x170/0x4e0 | sp=E000000003177de0 bsp=E000000003170e00 | [] kernel_thread_helper+0xd0/0x100 | sp=E000000003177e30 bsp=E000000003170dd0 | [] start_kernel_thread+0x20/0x40 | sp=E000000003177e30 bsp=E000000003170dd0 Looks like mbcs_init could use a platform check. Bruce, does this look ok? Signed-off-by: Greg Edwards drivers/char/mbcs.c | 3 +++ 1 files changed, 3 insertions(+) Index: git-linus/drivers/char/mbcs.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D--- git-linus.orig/drivers/char/mbcs.c 2005-09-12 1= 1:34:37.639213202 -0500 +++ git-linus/drivers/char/mbcs.c 2005-09-28 12:37:02.756895426 -0500 @@ -830,6 +830,9 @@ static int __init mbcs_init(void) { int rv; =20 + if (!ia64_platform_is("sn2")) + return -ENODEV; + // Put driver into chrdevs[]. Get major number. rv =3D register_chrdev(mbcs_major, DEVICE_NAME, &mbcs_ops); if (rv < 0) {