Re: [Patch 2/2] Special Memory (mspec) driver.

Robin Holt
2005-10-14T18:09:46Z

On Thu, Oct 13, 2005 at 10:12:05PM -0700, Dave Hansen wrote:
> On Wed, 2005-10-12 at 14:42 -0500, Robin Holt wrote:
> ...
>
> Looks like you could un-indent almost the entire function of you just
> did this instead:
>
> if (!atomic_dec_and_test(&vdata->refcnt))
> return;

Done

>
> This looks pretty similar to get_one_pte_map(). Is there enough
> commonality to use it?
>

Added an extra patch to export get_one_pte_map and used that instead.

> How about:
>
> vdata = vmalloc(sizeof(struct vma_data) + pages * sizeof(long));
> if (!vdata)
> return -ENOMEM;

Done

> This whole thing really is a driver for a piece of arch-specific
> hardware, right? Does it really belong in /proc? You already have a
> misc device, so you already have some area in sysfs. Would that make a
> better place for it?

Most of the useful information for this was removed when the kernel
uncached allocator (and gen_alloc) were moved out of the earliest mspec.c.
Removed entirely.

> Isn't the general kernel style for these to keep the action out of the
> if() condition?
>
> ret = misc_register(&cached_miscdev);
> if (ret) {
> ...

Done.

Thanks,
Robin Holt