Re: [Patch 2/3] Export get_one_pte_map.

Hugh Dickins
2005-10-17T20:59:12Z

On Mon, 17 Oct 2005, Robin Holt wrote:
> On Mon, Oct 17, 2005 at 04:59:20PM +0100, Hugh Dickins wrote:
> > Repeating a technical question (sorry, that now seems off-topic!):
> > what do you expect to happen with PROT_WRITE, MAP_PRIVATE?
>
> That would end up with a MAP_PRIVATE, PROT_WRITE, VM_RESERVED
> mapping. That does not make sense for this device, so I added
> the following check to mspec_mmap()
>
> if ((vma->vm_flags & VM_SHARED) = 0)
> return -EINVAL;

Great, that saves us (or at least postpones) some nastiness!

Thanks,
Hugh