From: Bob Picco <bob.picco@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] fix memory less node allocation
Date: Fri, 04 Nov 2005 00:10:39 +0000 [thread overview]
Message-ID: <20051104001039.GC22938@localhost.localdomain> (raw)
In-Reply-To: <20051029212305.GA6019@localhost.localdomain>
luck wrote: [Thu Nov 03 2005, 05:33:53PM EST]
> - if (!ptr)
> - panic("NO memory for memory less node\n");
>
> Why did you drop this panic? Although your patch now
> makes sure to never try to alloc from a memory less
> node ... surely it is still possible (though unlikely)
> that the call to __alloc_bootmem_node() might fail. A
> panic here might be easier to debug than letting it run
> until fill_pernode() does a memset(__va(0), 0, ...).
>
> -Tony
I dropped it because it seemed redundant. __alloc_bootmem_node calls
__alloc_bootmem_node_limit who calls __alloc_bootmem_core for this
node. Should __alloc_bootmem_core core fail, then call __alloc_bootmem_limit.
__alloc_bootmem_limit attempts to allocate from any node. Should
__alloc_bootmem_limit (old name __alloc_bootmem) fail, then it panics.
bob
prev parent reply other threads:[~2005-11-04 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 21:23 [PATCH] fix memory less node allocation Bob Picco
2005-11-03 22:33 ` Luck, Tony
2005-11-04 0:10 ` Bob Picco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051104001039.GC22938@localhost.localdomain \
--to=bob.picco@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox