From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Fix missing parameter for local_add
Date: Wed, 07 Dec 2005 19:29:21 +0000 [thread overview]
Message-ID: <200512071229.21568.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0512071053450.24789@schroedinger.engr.sgi.com>
On Wednesday 07 December 2005 11:54 am, Christoph Lameter wrote:
> Local add needs to have a parameter that specifies how much to add
> to a local_t. atomic64_add also requires two parameters.
AOL: what about local_sub()?
> Index: linux-2.6.15-rc5/include/asm-ia64/local.h
> =================================> --- linux-2.6.15-rc5.orig/include/asm-ia64/local.h 2005-12-03 21:10:42.000000000 -0800
> +++ linux-2.6.15-rc5/include/asm-ia64/local.h 2005-12-06 14:39:47.000000000 -0800
> @@ -17,7 +17,7 @@ typedef struct {
> #define local_set(l, i) atomic64_set(&(l)->val, i)
> #define local_inc(l) atomic64_inc(&(l)->val)
> #define local_dec(l) atomic64_dec(&(l)->val)
> -#define local_add(l) atomic64_add(&(l)->val)
> +#define local_add(i, l) atomic64_add((i), &(l)->val)
> #define local_sub(l) atomic64_sub(&(l)->val)
>
> /* Non-atomic variants, i.e., preemption disabled and won't be touched in interrupt, etc. */
> -
next prev parent reply other threads:[~2005-12-07 19:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 18:54 [PATCH] Fix missing parameter for local_add Christoph Lameter
2005-12-07 19:02 ` Luck, Tony
2005-12-07 19:24 ` Christoph Lameter
2005-12-07 19:29 ` Bjorn Helgaas [this message]
2005-12-07 19:36 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512071229.21568.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox