public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: hawkes@sgi.com
Cc: tony.luck@gmail.com, linux-ia64@vger.kernel.org,
	linux-kernel@vger.kernel.org, steiner@sgi.com, kaos@sgi.com
Subject: Re: [PATCH] ia64: eliminate softlockup warning
Date: Wed, 14 Dec 2005 23:16:13 +0000	[thread overview]
Message-ID: <20051214151613.2afc35b2.akpm@osdl.org> (raw)
In-Reply-To: <20051214230713.7528.68477.sendpatchset@tomahawk.engr.sgi.com>

hawkes@sgi.com wrote:
>
> Fix an unnecessary softlockup watchdog warning in the ia64
> uncached_build_memmap() that occurs occasionally at 256p and always at
> 512p.  The problem occurs at boot time.
> 
> It would be good if we had a cleaner mechanism to temporarily silence
> the watchdog thread, e.g.,
>     http://marc.theaimsgroup.com/?l=linux-kernel&m\x111552476401175&w=2
> but until that patch gets merged, this fix will have to suffice.
> 

That patch is for the hangcheck timer driver which is unrelated to the
softlockup detector.

> 
> Index: linux/arch/ia64/kernel/uncached.c
> =================================> --- linux.orig/arch/ia64/kernel/uncached.c	2005-12-06 15:12:14.000000000 -0800
> +++ linux/arch/ia64/kernel/uncached.c	2005-12-14 14:50:55.000000000 -0800
> @@ -210,6 +210,7 @@
>  
>  	dprintk(KERN_ERR "uncached_build_memmap(%lx %lx)\n", start, end);
>  
> +	touch_softlockup_watchdog();
>  	memset((char *)start, 0, length);
>  
>  	node = paddr_to_nid(start - __IA64_UNCACHED_OFFSET);

Yes, additions like this are a bit awkward, but they're not _that_ bad.  It
says "this code is doing something unusual".  It's an explicit marker which
we can grep for and which conveys useful information about an exceptional
kernel state.

  reply	other threads:[~2005-12-14 23:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-14 23:07 [PATCH] ia64: eliminate softlockup warning hawkes
2005-12-14 23:16 ` Andrew Morton [this message]
2005-12-14 23:23 ` hawkes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051214151613.2afc35b2.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=hawkes@sgi.com \
    --cc=kaos@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steiner@sgi.com \
    --cc=tony.luck@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox