From: "Luck, Tony" <tony.luck@intel.com>
To: hawkes@sgi.com
Cc: Tony Luck <tony.luck@gmail.com>, Andrew Morton <akpm@osdl.org>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
Jack Steiner <steiner@sgi.com>, Keith Owens <kaos@sgi.com>,
Dimitri Sivanich <sivanich@sgi.com>
Subject: Re: [PATCH] ia64: disable preemption in udelay()
Date: Fri, 16 Dec 2005 01:04:40 +0000 [thread overview]
Message-ID: <20051216010440.GA9886@agluck-lia64.sc.intel.com> (raw)
In-Reply-To: <20051215225040.GA9086@agluck-lia64.sc.intel.com>
On Thu, Dec 15, 2005 at 02:50:40PM -0800, Luck, Tony wrote:
> This does make the function a bit big for an "inline" though. Does
> it really need to be inline? Do we care how fast our delay loops
> are?
Moving the current slim-line udelay() out of line would save 41 Kbytes
of text in the generic vmlinux, plus making any modules that use
udelay smaller too. Savings run from a 128-160 bytes for drivers
with just one call to a max of 9 Kbytes for qla2xxx.ko.
Being out-of-line would reduce accuracy, but this would only be
significant when the sleep is for a very small number of microseconds.
So if we need to add more code to udelay(), I think that it
should be moved out-of-line too (into arch/ia64/kernel/time.c).
alpha, m68knommu, powerpc and sh64 already have out of line udelay().
-Tony
next prev parent reply other threads:[~2005-12-16 1:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 23:25 [PATCH] ia64: disable preemption in udelay() hawkes
2005-12-15 22:50 ` Luck, Tony
2005-12-16 1:04 ` Luck, Tony [this message]
2005-12-16 8:20 ` Christian Hildner
2005-12-16 14:14 ` Alan Cox
2005-12-16 1:52 ` Zwane Mwaikambo
2005-12-16 2:03 ` Lee Revell
2005-12-16 2:12 ` John Hawkes
2005-12-16 2:40 ` Zwane Mwaikambo
2005-12-16 3:19 ` Lee Revell
2005-12-22 21:45 ` Bill Davidsen
2005-12-16 2:37 ` Zwane Mwaikambo
2005-12-16 2:42 ` hawkes
2005-12-16 12:28 ` Robin Holt
2005-12-16 17:33 ` Luck, Tony
2005-12-16 18:39 ` John Hawkes
2005-12-23 0:14 ` Keith Owens
2005-12-23 5:58 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051216010440.GA9886@agluck-lia64.sc.intel.com \
--to=tony.luck@intel.com \
--cc=akpm@osdl.org \
--cc=hawkes@sgi.com \
--cc=kaos@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sivanich@sgi.com \
--cc=steiner@sgi.com \
--cc=tony.luck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox