From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Maule Date: Thu, 22 Dec 2005 20:38:24 +0000 Subject: Re: [PATCH 0/3] msi abstractions and support for altix Message-Id: <20051222203824.GJ17552@sgi.com> List-Id: References: <20051222201651.2019.37913.96422@lnx-maule.americas.sgi.com> <20051222202259.GA4959@suse.de> <20051222202627.GI17552@sgi.com> <20051222203415.GA28240@suse.de> In-Reply-To: <20051222203415.GA28240@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg KH Cc: linuxppc64-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Luck On Thu, Dec 22, 2005 at 12:34:15PM -0800, Greg KH wrote: > On Thu, Dec 22, 2005 at 02:26:27PM -0600, Mark Maule wrote: > > On Thu, Dec 22, 2005 at 12:22:59PM -0800, Greg KH wrote: > > > On Thu, Dec 22, 2005 at 02:15:44PM -0600, Mark Maule wrote: > > > > Resend #2: including linuxppc64-dev and linux-pci as well as PCI maintainer > > > > > > I'll wait for Resend #3 based on my previous comments before considering > > > adding it to my kernel trees:) > > > > > > > Resend #2 includes the correction to the irq_vector[] declaration, and I > > responded to the question about setting irq_vector[0] if that's what you > > mean ... > > Sorry, but I missed that last response. Why do you set the [0] value in > a #ifdef now? Because on ia64 IA64_FIRST_DEVICE_VECTOR and IA64_LAST_DEVICE_VECTOR (from which MSI FIRST_DEVICE_VECTOR/LAST_DEVICE_VECTOR are derived) are not constants. The are now global variables (see change to asm-ia64/hw_irq.h) to allow the platform to override them. Altix uses a reduced range of vectors for devices, and this change was necessary to make assign_irq_vector() to work on altix. Mark