Re: [PATCH 0/3] msi abstractions and support for altix

David S. Miller
2006-03-21T21:53:59Z

From: Mark Maule <maule@sgi.com>
Date: Tue, 21 Mar 2006 08:34:44 -0600 (CST)

> Mark
>
> 1/3 msi-ops.patch
> Add an msi_arch_init() hook which can be used to perform platform
> specific setup prior to msi use.
>
> Define a set of msi ops to implement the platform-specific tasks:
>
> setup - set up plumbing to get a vector directed at a default
> cpu, and return the corresponding MSI bus address and data.
> teardown - inverse of msi_setup
> target - retarget a vector to a given cpu
>
> Define the routine msi_register() called from msi_arch_init()
> to set the desired ops.
>
> Move a bunch of apic-specific code out of the msi core .h/.c and
> into a new msi-apic.c file.

Mark, thanks for doing this work. The better abstracted out the
so-called generic MSI support code is, the better. Several platforms
will benefit from this, such as PPC and Sparc64, both of which
cannot take advantage of MSI support in their PCI controllers because
of how x86 centric the current MSI support layer is.

Thanks again.