Re: [PATCH 1/3] msi vector targeting abstractions

Greg KH
2006-01-04T00:27:38Z

On Tue, Jan 03, 2006 at 04:20:47PM -0800, Grant Grundler wrote:
> On Tue, Jan 03, 2006 at 05:50:24PM -0600, Mark Maule wrote:
> > > > +struct msi_ops msi_apic_ops = {
> > > > + .setup = msi_setup_apic,
> > > > + .teardown = msi_teardown_apic,
> > > > +#ifdef CONFIG_SMP
> > > > + .target = msi_target_apic,
> > > > +#endif
> > >
> > > Mark,
> > > msi_target_apic() initializes address_lo parameter.
> > > Even on a UP machine, we need inialize this value.
> >
> > Not sure what you mean here. target is used to retarget an existing
> > MSI vector to a different processor.
>
> Right - I didn't realize the caller, set_msi_affinity(), was surrounded by
> "#ifdef CONFIG_SMP".
>
> But set_msi_affinity() appears to be dead code.
> I couldn't find any calls to set_msi_affinity() in 2.6.14 or 2.6.15.
> Greg, you want a patch to remove that?

Yes please, that would be great to have.

thanks,

greg k-h