Re: [PATCH 1/3] msi vector targeting abstractions

Greg KH
2006-01-12T05:36:22Z

On Wed, Jan 11, 2006 at 10:02:43PM -0700, Grant Grundler wrote:
> On Wed, Jan 11, 2006 at 09:52:56AM -0600, Mark Maule wrote:
> > Abstract portions of the MSI core for platforms that do not use standard
> > APIC interrupt controllers. This is implemented through a new arch-specific
> > msi setup routine, and a set of msi ops which can be set on a per platform
> > basis.
> ...
> > Index: linux-maule/drivers/pci/msi.c
> ...
> > + if ((status = msi_arch_init()) < 0) {
>
> Willy told me I should always complain about assignment in if() statements :)
>
> Greg, I volunteer to submit a patch to fix all occurances in pci/msi.c
> including the one above. I can prepare that this weekend on my own time.
> Is that ok?

Yes, that would be wonderful to have.

thanks,

greg k-h