Re: [PATCH 2/3] per-platform IA64_{FIRST,LAST}_DEVICE_VECTOR definitions

Greg KH
2005-12-22T20:01:11Z

On Thu, Dec 22, 2005 at 11:15:19AM -0600, Mark Maule wrote:
> --- msi.orig/drivers/pci/msi.c 2005-12-21 16:10:32.838675711 -0600
> +++ msi/drivers/pci/msi.c 2005-12-21 18:55:05.020985381 -0600
> @@ -35,7 +35,7 @@
>
> #ifndef CONFIG_X86_IO_APIC
> int vector_irq[NR_VECTORS] = { [0 ... NR_VECTORS - 1] = -1};
> -u8 irq_vector[NR_IRQ_VECTORS] = { FIRST_DEVICE_VECTOR , 0 };
> +u8 irq_vector[NR_IRQ_VECTORS] = { [0 ... NR_IRQ_VECTORS - 1 ] = 0 };

As previously mentioned, you don't have to initilize this to 0.

> #endif
>
> static struct msi_ops *msi_ops;
> @@ -377,6 +377,11 @@
> printk(KERN_WARNING "PCI: MSI cache init failed\n");
> return status;
> }
> +
> +#ifndef CONFIG_X86_IO_APIC
> + irq_vector[0] = FIRST_DEVICE_VECTOR;
> +#endif

Why do this here, what's wrong with the original code above in the
static declaration? Or am I missing some logic change somewhere?

thanks,

greg k-h