Re: [PATCH 1/3] msi vector targeting abstractions

Greg KH
2006-01-12T17:17:09Z

On Thu, Jan 12, 2006 at 08:55:15AM -0800, Joe Perches wrote:
> On Thu, 2006-01-12 at 00:33 -0700, Grant Grundler wrote:
> > On Thu, Jan 12, 2006 at 04:47:27PM +1100, Paul Mackerras wrote:
> > > Grant Grundler writes:
> > > > > + if ((status = msi_arch_init()) < 0) {
> > > > Willy told me I should always complain about assignment in if() statements :)
> > > We are getting incredibly politically correct these days, aren't we.
> > I'm not asking greg to reject the patch nor dictating Mark Mauler change it.
> > Since greg is willing to accept a patch to "fix" it, I'm willing to provide
> > the patch in this case. I think that's fairly normal way to clean things up.
>
> (me too)
>
> Here's a patch for drivers/pci

-ENOCHANGELOGANDSIGNEDOFFBYLINE :(