From: Paul Jackson <pj@sgi.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com, linux-ia64@vger.kernel.org
Subject: Re: [CFT 9/29] Add tiocx bus_type probe/remove methods
Date: Thu, 12 Jan 2006 09:45:51 +0000 [thread overview]
Message-ID: <20060112014551.8e7888c3.pj@sgi.com> (raw)
In-Reply-To: <20060105142951.13.09@flint.arm.linux.org.uk>
This patch looks broken. I see the lines:
+ .remove = cx_device_remove,
- cx_driver->driver.remove = cx_driver_remove;
The routine (not in this patch) is still known as "cx_driver_remove"
but now it is linked to from the .remove line as "cx_device_remove"
A defconfig ia64 build of *-mm3 with this patch fails:
arch/ia64/sn/kernel/tiocx.c:151: error: `cx_device_remove' undeclared here (not in a function)
arch/ia64/sn/kernel/tiocx.c:151: error: initializer element is not constant
arch/ia64/sn/kernel/tiocx.c:151: error: (near initialization for `tiocx_bus_type.remove')
arch/ia64/sn/kernel/tiocx.c:137: warning: `cx_driver_remove' defined but not used
When I s/cx_device_remove/cx_driver_remove/, then ia64 *-mm3 defconfig builds fine.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2006-01-12 9:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060105142951.13.01@flint.arm.linux.org.uk>
2006-01-05 14:34 ` [CFT 9/29] Add tiocx bus_type probe/remove methods Russell King
2006-01-12 9:45 ` Paul Jackson [this message]
2006-01-12 10:31 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060112014551.8e7888c3.pj@sgi.com \
--to=pj@sgi.com \
--cc=greg@kroah.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox