Re: [PATCH 1/12] generic *_bit()

Anton Altaparmakov
2006-02-02T08:52:11Z

On Wed, 1 Feb 2006, Grant Grundler wrote:
> On Wed, Feb 01, 2006 at 10:49:08PM +0000, Anton Altaparmakov wrote:
> > Err, searching by anything other than bytes is useless for a file system
> > driver. Otherwise you get all sorts of disgustingly horrible allocation
> > patterns depending on the endianness of the machine...
>
> Well, tell that to ext2/3 maintainers since they introduced
> the ext2_test_bit() and friends. They do require LE handling
> of the bit array since that's an on-disk format. See how big endian
> machines (parisc/ppc/sparc/etc) deal with it in asm/bitops.h.

Oh, I hadn't noticed those before. Thanks.

The name seems a bit silly as I imagine most fs drivers would be able to
use them and there already are ext2 and minix versions. Probably ought
be renamed to a more generic name like le_test_bit() or something...

Best regards,

Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/