From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Thu, 26 Jan 2006 16:14:27 +0000 Subject: Re: [PATCH 1/6] {set,clear,test}_bit() related cleanup Message-Id: <20060126161426.GA1709@elf.ucw.cz> List-Id: References: <20060125112625.GA18584@miraclelinux.com> <20060125112857.GB18584@miraclelinux.com> In-Reply-To: <20060125112857.GB18584@miraclelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , Russell King , Ian Molton , dev-etrax@axis.com, David Howells , Yoshinori Sato , Linus Torvalds , linux-ia64@vger.kernel.org, Hirokazu Takata , linux-m68k@vger.kernel.org, Greg Ungerer , linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, linuxppc-dev@ozlabs.org, linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Andi Kleen , Chris Zankel Hi! > While working on these patch set, I found several possible cleanup > on x86-64 and ia64. It is probably not your fault, but... > Index: 2.6-git/include/asm-x86_64/mmu_context.h > =================================> --- 2.6-git.orig/include/asm-x86_64/mmu_context.h 2006-01-25 19:07:15.000000000 +0900 > +++ 2.6-git/include/asm-x86_64/mmu_context.h 2006-01-25 19:13:59.000000000 +0900 > @@ -34,12 +34,12 @@ > unsigned cpu = smp_processor_id(); > if (likely(prev != next)) { > /* stop flush ipis for the previous mm */ > - clear_bit(cpu, &prev->cpu_vm_mask); > + cpu_clear(cpu, prev->cpu_vm_mask); > #ifdef CONFIG_SMP > write_pda(mmu_state, TLBSTATE_OK); > write_pda(active_mm, next); > #endif > - set_bit(cpu, &next->cpu_vm_mask); > + cpu_set(cpu, next->cpu_vm_mask); > load_cr3(next->pgd); > > if (unlikely(next->context.ldt != prev->context.ldt)) cpu_set sounds *very* ambiguous. We have thing called cpusets, for example. I'd not guess that is set_bit in cpu endianity (is it?). Pavel -- Thanks, Sharp!