Re: [PATCH 8/12] generic hweight{32,16,8}()

Bryan O'Sullivan
2006-01-27T05:23:47Z

On Fri, 2006-01-27 at 13:43 +0900, Akinobu Mita wrote:

> I think it's better than adding many HAVE_ARCH_*_BITOPS.
> I will have 14 new headers. So I want to make new directory
> include/asm-generic/bitops/:

While you're thrashing all that stuff, have you thought about adding
generic support for the atomic_*_mask functions? Only eight of almost
30 arches actually implement them, which makes them worthless for
portable drivers. The same approach you're using now with other bitops
will work equally well, or be just as broken, depending on the arch in
question :-)

<b