From: "Luck, Tony" <tony.luck@intel.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch 5/5] fix sn rw_mmr.h to use intrinsic
Date: Tue, 31 Jan 2006 18:08:57 +0000 [thread overview]
Message-ID: <20060131180857.GA8442@agluck-lia64.sc.intel.com> (raw)
In-Reply-To: <200601270137.k0R1big21236@unix-os.sc.intel.com>
On Tue, Jan 31, 2006 at 11:19:35AM +0000, Christoph Hellwig wrote:
> Agreed. Obsfucating for a propritary and pretty much irrelevant (for the
> kernel) compiler is a horrible thing to do. And the only reason we do that
> at all is that the compiler is from the same company that's behind ia64.
> Please fix up your damn compiler. Even SGI managed to add proper inline
> as?embly support to Pro64, and they had much less ressources.
How about we un-obfuscate the code by moving these three functions to
a ".S" file? They are reading from uncached physical memory, and are
packed full of "srlz.i" and ".acq"/".rel" options, so it doesn't appear
that moving them from inline to a full procedure call would make any
measurable difference to performance (at least not for any macrobenchmark).
pio_phys_read_mmr() isn't even used anyplace, so we could further clarify
the code by dropping it altogether.
-Tony
next prev parent reply other threads:[~2006-01-31 18:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 1:37 [patch 5/5] fix sn rw_mmr.h to use intrinsic Chen, Kenneth W
2006-01-27 3:57 ` Chen, Kenneth W
2006-01-27 9:57 ` Jes Sorensen
2006-01-27 23:35 ` Chen, Kenneth W
2006-01-31 10:57 ` Jes Sorensen
2006-01-31 11:19 ` Christoph Hellwig
2006-01-31 18:08 ` Luck, Tony [this message]
2006-02-02 9:39 ` Jes Sorensen
2006-02-02 14:18 ` Jack Steiner
2006-02-02 18:54 ` Luck, Tony
2006-02-02 21:01 ` Jes Sorensen
2006-02-03 23:40 ` Gerald Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060131180857.GA8442@agluck-lia64.sc.intel.com \
--to=tony.luck@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox