From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Kenneth W" Date: Wed, 08 Feb 2006 22:24:51 +0000 Subject: RE: [2.6 patch] let IA64_GENERIC select more stuff Message-Id: <200602082224.k18MOpg24612@unix-os.sc.intel.com> List-Id: In-Reply-To: <20060208213825.GQ3524@stusta.de> References: <20060207231713.GG3524@stusta.de> In-Reply-To: <20060207231713.GG3524@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'Adrian Bunk' , Jes Sorensen Cc: 'Keith Owens' , "Luck, Tony" , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org Adrian Bunk wrote on Wednesday, February 08, 2006 1:38 PM > > Not really, it helps a bit by selecting some things we know we need > > for all GENERIC builds. True we can't make it bullet proof, but whats > > there is better than removing it. > > Like the bug of allowing the illegal configuration NUMA=y, FLATMEM=y? You can't even compile a kernel with that combination ... Just about every arch except ia64 turns off ARCH_FLATMEM_ENABLE if NUMA=y. ia64 can just do the same thing. Instead of mucking around with select, fix the bug at its source. The real culprit is in mm/Kconfig, it shouldn't enable ARCH_FLATMEM_ENABLE if NUMA=y. Fix ARCH_FLATMEM_ENABLE dependency in ia64 arch. Signed-off-by: Ken Chen --- ./arch/ia64/Kconfig.orig 2006-02-08 14:57:40.597354431 -0800 +++ ./arch/ia64/Kconfig 2006-02-08 15:04:15.552427718 -0800 @@ -298,7 +298,8 @@ config ARCH_DISCONTIGMEM_ENABLE See for more. config ARCH_FLATMEM_ENABLE - def_bool y + depends on !NUMA + def_bool y if !NUMA config ARCH_SPARSEMEM_ENABLE def_bool y