RE: [2.6 patch] let IA64_GENERIC select more stuff

Chen, Kenneth W
2006-02-08T01:40:13Z

Adrian Bunk wrote on Tuesday, February 07, 2006 5:20 PM
> You could ask the same question for NUMA:
> Select generic system type does not mean NUMA systems are only choice I
> can have. What's wrong with having an option that works just fine?

Please read more ia64 arch specific code ...

CONFIG_IA64_GENERIC is a platform type choice, you can have platform
type of DIG, HPZX1, SGI SN2, or all of the above. DIG platform depends
on ACPI, thus need ACPI on. SGI altix is a numa box, thus, need NUMA
on. NEC, Fujitsu build numa machines with ACPI SRAT table, thus, need
ACPI_NUMA on. When you build a kernel to boot on all platforms, you
have no choice but to turn on all of the above. Processor type and SMP
is different from platform type. It does not have any dependency on
platform type. They are orthogonal choice.

> Keith said IA64_GENERIC should select all the options required in
> order to run on all the IA64 platforms out there.
^^^^^^^^^^^^^^
> This is what my patch does.

You patch does more than what you described and is wrong. Selecting
platform type should not be tied into selecting SMP nor should it tied
with processor type, nor should it tied with ARCH_FLATMEM_ENABLE. All
of them are orthogonal and independent.

Theoretically and maybe academically interesting, I should be able to
build a kernel that boots on all UP platforms, with your patch, that
is not possible.

- Ken