public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Andi Kleen <ak@suse.de>, "Luck, Tony" <tony.luck@intel.com>,
	"Tolentino, Matthew E" <matthew.e.tolentino@intel.com>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org, x86-64 Discuss <discuss@x86-64.org>,
	Linux Hotplug Memory Support <lhms-devel@lists.sourceforge.net>
Subject: [RFC/PATCH: 004/010] Memory hotplug for new nodes with pgdat allocation. (pgdat alloc caller for x86
Date: Fri, 10 Feb 2006 14:21:02 +0000	[thread overview]
Message-ID: <20060210224257.C536.Y-GOTO@jp.fujitsu.com> (raw)

This is sample code of calling pgdat allocation function for x86_64.
Basically it is same with ia64. 

I've not tried this patch yet, due to I couldn't make emulation for
new node addtion for x86_64. This is just to reference. :-P

Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>

Index: pgdat2/arch/x86_64/mm/init.c
=================================--- pgdat2.orig/arch/x86_64/mm/init.c	2006-02-10 17:29:20.000000000 +0900
+++ pgdat2/arch/x86_64/mm/init.c	2006-02-10 17:30:42.000000000 +0900
@@ -26,6 +26,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/module.h>
 #include <linux/memory_hotplug.h>
+#include <linux/acpi.h>
 
 #include <asm/processor.h>
 #include <asm/system.h>
@@ -494,11 +495,25 @@ void online_page(struct page *page)
 
 int add_memory(u64 start, u64 size)
 {
-	struct pglist_data *pgdat = NODE_DATA(0);
-	struct zone *zone = pgdat->node_zones + MAX_NR_ZONES-2;
+	struct pglist_data *pgdat;
+	struct zone *zone;
 	unsigned long start_pfn = start >> PAGE_SHIFT;
 	unsigned long nr_pages = size >> PAGE_SHIFT;
-	int ret;
+	int ret, node, new_pgdat = 0;
+
+	node = acpi_paddr_to_node(start, size);
+
+	if (node < 0)
+		node = 0; /* pxm is undefined in DSDT.
+			     This might be non NUMA case */
+
+	if (!node_online(node)) {
+		ret = new_pgdat_init(node, start_pfn, nr_pages);
+		if (ret)
+			goto err;
+		new_pgdat = 1;
+	}
+
 
 	ret = __add_pages(zone, start_pfn, nr_pages);
 	if (ret)
@@ -509,6 +524,9 @@ int add_memory(u64 start, u64 size)
 	return ret;
 error:
 	printk("%s: Problem encountered in __add_pages!\n", __func__);
+	if (new_pgdat)
+		release_pgdat(ret);
+
 	return ret;
 }
 EXPORT_SYMBOL_GPL(add_memory);

-- 
Yasunori Goto 



             reply	other threads:[~2006-02-10 14:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-10 14:21 Yasunori Goto [this message]
2006-02-10 17:15 ` [discuss] [RFC/PATCH: 004/010] Memory hotplug for new nodes with pgdat allocation. (pgdat alloc Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060210224257.C536.Y-GOTO@jp.fujitsu.com \
    --to=y-goto@jp.fujitsu.com \
    --cc=ak@suse.de \
    --cc=discuss@x86-64.org \
    --cc=lhms-devel@lists.sourceforge.net \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.e.tolentino@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox