public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: "Luck, Tony" <tony.luck@intel.com>, Andi Kleen <ak@suse.de>,
	"Tolentino, Matthew E" <matthew.e.tolentino@intel.com>
Cc: x86-64 Discuss <discuss@x86-64.org>,
	Linux Kernel ML <linux-kernel@vger.kernel.org>,
	linux-ia64@vger.kernel.org,
	Linux Hotplug Memory Support <lhms-devel@lists.sourceforge.net>
Subject: [RFC/PATCH: 007/010] Memory hotplug for new nodes with pgdat allocation. (pgdat link insert)
Date: Fri, 10 Feb 2006 14:21:23 +0000	[thread overview]
Message-ID: <20060210224529.C53E.Y-GOTO@jp.fujitsu.com> (raw)

This is to insert pgdat to its link.
To be honest, I would like remove this pgdat link, and
I posted patches to remove it for a long time ago to -mm.

http://marc.theaimsgroup.com/?l=linux-mm&m\x112808582217281&w=2
http://marc.theaimsgroup.com/?l=linux-mm&m\x112808582227966&w=2

But, it might have influence against performance for big NUMA box.
So, I should check it.
However, I'm very hard to access big NUMA box. Our machine is 
divided as small partitioned for test of each team inside of fujitsu
every time. Sigh. :-(. 

This is small lazy patch instead of them.

Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>

Index: pgdat2/arch/ia64/mm/discontig.c
=================================--- pgdat2.orig/arch/ia64/mm/discontig.c	2006-02-10 17:40:05.000000000 +0900
+++ pgdat2/arch/ia64/mm/discontig.c	2006-02-10 19:42:27.000000000 +0900
@@ -384,7 +384,7 @@ static void __init *memory_less_node_all
  * pgdat_insert - insert the pgdat into global pgdat_list
  * @pgdat: the pgdat for a node.
  */
-static void __init pgdat_insert(pg_data_t *pgdat)
+void __meminit pgdat_insert(pg_data_t *pgdat)
 {
 	pg_data_t *prev = NULL, *next;
 
Index: pgdat2/arch/ia64/mm/init.c
=================================--- pgdat2.orig/arch/ia64/mm/init.c	2006-02-10 17:29:30.000000000 +0900
+++ pgdat2/arch/ia64/mm/init.c	2006-02-10 19:42:41.000000000 +0900
@@ -647,6 +647,8 @@ void online_page(struct page *page)
 	num_physpages++;
 }
 
+extern void __meminit pgdat_insert(pg_data_t *pgdat);
+
 int add_memory(u64 start, u64 size)
 {
 	pg_data_t *pgdat;
@@ -663,6 +665,7 @@ int add_memory(u64 start, u64 size)
 
 	if (!node_online(node)){
 		ret = new_pgdat_init(node, start_pfn, nr_pages);
+		pgdat_insert(NODE_DATA(node));
 		if (ret)
 			return ret;
 

-- 
Yasunori Goto 



                 reply	other threads:[~2006-02-10 14:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060210224529.C53E.Y-GOTO@jp.fujitsu.com \
    --to=y-goto@jp.fujitsu.com \
    --cc=ak@suse.de \
    --cc=discuss@x86-64.org \
    --cc=lhms-devel@lists.sourceforge.net \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.e.tolentino@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox