public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: "Luck, Tony" <tony.luck@intel.com>, Andi Kleen <ak@suse.de>,
	"Tolentino, Matthew E" <matthew.e.tolentino@intel.com>,
	linux-ia64@vger.kernel.org,
	Linux Kernel ML <linux-kernel@vger.kernel.org>,
	x86-64 Discuss <discuss@x86-64.org>,
	Linux Hotplug Memory Support <lhms-devel@lists.sourceforge.net>,
	Hiroyuki KAMEZAWA <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [Lhms-devel] [RFC/PATCH: 002/010] Memory hotplug for new nodes with pgdat allocation. (Wait tabl
Date: Sat, 11 Feb 2006 04:15:17 +0000	[thread overview]
Message-ID: <20060211125941.D35C.Y-GOTO@jp.fujitsu.com> (raw)
In-Reply-To: <1139589128.9209.80.camel@localhost.localdomain>



> On Fri, 2006-02-10 at 23:20 +0900, Yasunori Goto wrote:
> > 
> >  static __meminit
> >  void zone_wait_table_init(struct zone *zone, unsigned long
> > zone_size_pages)
> >  {
> > -       int i;
> > +       int i, hotadd = (system_state = SYSTEM_RUNNING);
> >         struct pglist_data *pgdat = zone->zone_pgdat;
> > +       unsigned long allocsize;
> >  
> >         /*
> >          * The per-page waitqueue mechanism uses hashed waitqueues
> >          * per zone.
> >          */
> > +       if (hotadd && (zone_size_pages = PAGES_PER_SECTION))
> > +               zone_size_pages = PAGES_PER_SECTION << 2; 
> 
> I don't think I understand this calculation.  You online only 4 sections
> worth of pages?

Ummmmm.
I realized that I've forgotten many things about this patch
due to long time keeping in storage. 
At least here looks strange indeed.
I need shake my brain to recall it. :-(


-- 
Yasunori Goto 




  reply	other threads:[~2006-02-11  4:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-10 14:20 [RFC/PATCH: 002/010] Memory hotplug for new nodes with pgdat allocation. (Wait table and zonelists i Yasunori Goto
2006-02-10 16:32 ` [Lhms-devel] [RFC/PATCH: 002/010] Memory hotplug for new nodes Dave Hansen
2006-02-11  4:15   ` Yasunori Goto [this message]
2006-02-11 10:58     ` Kamezawa Hiroyuki
2006-02-14 13:24       ` [Lhms-devel] [RFC/PATCH: 002/010] Memory hotplug for new nodes with pgdat allocation. (Wait tabl Yasunori Goto
2006-02-15  1:06         ` [Lhms-devel] [RFC/PATCH: 002/010] Memory hotplug for new nodes KAMEZAWA Hiroyuki
2006-02-10 16:33 ` Dave Hansen
2006-02-14  7:34   ` [Lhms-devel] [RFC/PATCH: 002/010] Memory hotplug for new nodes with pgdat allocation. (Wait tabl Yasunori Goto
2006-02-10 21:59 ` [Lhms-devel] [RFC/PATCH: 002/010] Memory hotplug for new nodes Joel Schopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060211125941.D35C.Y-GOTO@jp.fujitsu.com \
    --to=y-goto@jp.fujitsu.com \
    --cc=ak@suse.de \
    --cc=discuss@x86-64.org \
    --cc=haveblue@us.ibm.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=lhms-devel@lists.sourceforge.net \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.e.tolentino@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox