From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Thomas Renninger <trenn@suse.de>,
"Moore, Robert" <robert.moore@intel.com>,
"Luck, Tony" <tony.luck@intel.com>,
"Brown, Len" <len.brown@intel.com>,
linux-acpi@vger.kernel.org, linux-ia64@vger.kernel.org,
Andrew Morton <akpm@osdl.org>,
efocht@hpce.nec.com
Subject: [PATCH] ACPI: fix vendor resource length computation
Date: Tue, 14 Feb 2006 23:13:09 +0000 [thread overview]
Message-ID: <200602141613.09152.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200602131722.28703.bjorn.helgaas@hp.com>
acpi_rs_get_list_length() needs to account for all the vendor-defined
data bytes. Failing to include these causes buffers to be sized too
small, which causes slab corruption when we later convert AML to
resources and run off the end of the buffer.
I'm no expert on this code, so please scrutinize this carefully.
This causes slab corruption on machines that use ACPI vendor-defined
resources. All HP ia64 machines do, and I'm told that some NEC
machines may as well. So if the fix is correct, it would be good
to have it in 2.6.16.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work-mm4/drivers/acpi/resources/rscalc.c
=================================--- work-mm4.orig/drivers/acpi/resources/rscalc.c 2006-02-14 13:32:50.000000000 -0700
+++ work-mm4/drivers/acpi/resources/rscalc.c 2006-02-14 13:33:25.000000000 -0700
@@ -391,8 +391,7 @@
* Ensure a 32-bit boundary for the structure
*/
extra_struct_bytes - ACPI_ROUND_UP_to_32_bITS(resource_length) -
- resource_length;
+ ACPI_ROUND_UP_to_32_bITS(resource_length);
break;
case ACPI_RESOURCE_NAME_END_TAG:
@@ -408,8 +407,7 @@
* Add vendor data and ensure a 32-bit boundary for the structure
*/
extra_struct_bytes - ACPI_ROUND_UP_to_32_bITS(resource_length) -
- resource_length;
+ ACPI_ROUND_UP_to_32_bITS(resource_length);
break;
case ACPI_RESOURCE_NAME_ADDRESS32:
next prev parent reply other threads:[~2006-02-14 23:13 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-02 19:46 some new unaligned access while booting ia64 (HP rx2620) Luck, Tony
2006-02-02 22:28 ` Moore, Robert
2006-02-09 16:56 ` Moore, Robert
2006-02-09 20:44 ` Luck, Tony
2006-02-09 20:55 ` Moore, Robert
2006-02-09 21:04 ` Luck, Tony
2006-02-09 21:15 ` Luck, Tony
2006-02-09 23:43 ` Moore, Robert
2006-02-10 2:07 ` Thomas Renninger
2006-02-10 20:11 ` Moore, Robert
2006-02-10 21:15 ` Luck, Tony
2006-02-10 21:19 ` Moore, Robert
2006-02-10 21:54 ` Luck, Tony
2006-02-10 21:56 ` Moore, Robert
2006-02-10 22:58 ` Luck, Tony
2006-02-11 21:25 ` Bjorn Helgaas
2006-02-10 23:07 ` Moore, Robert
2006-02-10 23:15 ` Moore, Robert
2006-02-10 23:25 ` Luck, Tony
2006-02-10 23:31 ` Moore, Robert
2006-02-13 18:51 ` Thomas Renninger
2006-02-13 22:33 ` Bjorn Helgaas
2006-02-13 22:57 ` Andreas Schwab
2006-02-14 0:22 ` Bjorn Helgaas
2006-02-14 23:13 ` Bjorn Helgaas [this message]
2006-02-14 23:19 ` [PATCH] ACPI: fix vendor resource length computation Bjorn Helgaas
2006-02-14 23:25 ` Moore, Robert
2006-02-14 23:34 ` Bjorn Helgaas
2006-02-15 0:04 ` Moore, Robert
2006-02-15 17:49 ` Thomas Renninger
2006-02-15 18:38 ` Moore, Robert
2006-02-15 19:05 ` Luck, Tony
2006-02-16 8:59 ` Thomas Renninger
2006-02-16 22:54 ` Moore, Robert
2006-02-10 23:58 ` some new unaligned access while booting ia64 (HP rx2620) Luck, Tony
2006-02-11 0:39 ` Luck, Tony
2006-02-11 12:21 ` Robin Holt
2006-03-14 23:59 ` Bjorn Helgaas
2006-03-15 15:47 ` Moore, Robert
2006-03-15 16:49 ` Bjorn Helgaas
2006-03-15 17:14 ` Moore, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602141613.09152.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=akpm@osdl.org \
--cc=efocht@hpce.nec.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=robert.moore@intel.com \
--cc=schwab@suse.de \
--cc=tony.luck@intel.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox