From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: linux-ia64@vger.kernel.org
Subject: RE: missing entries in fsys.S
Date: Wed, 15 Feb 2006 19:16:02 +0000 [thread overview]
Message-ID: <200602151916.k1FJG2g09449@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060215143359.GB14787@frankl.hpl.hp.com>
Stephane Eranian wrote on Wednesday, February 15, 2006 8:28 AM
> I would certainly renamed
> the syscall_last to NR_fsyscalls_lat or something like this.
How does the following patch look? Is it better?
[patch] beautify coding style for zeroing end of fsyscall_table entries.
Remove misleading __NR_syscall_last and add more comments.
Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
--- linux-2.6.16-rc3/arch/ia64/kernel/fsys.S.orig 2006-02-15 11:39:52.221926956 -0800
+++ linux-2.6.16-rc3/arch/ia64/kernel/fsys.S 2006-02-15 12:05:28.789290945 -0800
@@ -878,8 +878,10 @@ fsyscall_table:
data8 0 // timer_delete
data8 0 // clock_settime
data8 fsys_clock_gettime // clock_gettime
- #define __NR_syscall_last 1255
- .space 8*(NR_syscalls + 1024 - __NR_syscall_last), 0
+ // fill in zeros for the remaining entries
+ .zero:
+ .space fsyscall_table + 8*NR_syscalls - .zero, 0
- .org fsyscall_table + 8*NR_syscalls // guard against failures to increase NR_syscalls
+ // guard against failures to increase NR_syscalls
+ .org fsyscall_table + 8*NR_syscalls
next prev parent reply other threads:[~2006-02-15 19:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-15 14:33 missing entries in fsys.S Stephane Eranian
2006-02-15 16:15 ` Chen, Kenneth W
2006-02-15 16:28 ` Stephane Eranian
2006-02-15 19:16 ` Chen, Kenneth W [this message]
2006-02-15 19:40 ` Luck, Tony
2006-02-15 19:58 ` Chen, Kenneth W
2006-02-15 20:04 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602151916.k1FJG2g09449@unix-os.sc.intel.com \
--to=kenneth.w.chen@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox