From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Andrew Morton <akpm@osdl.org>
Cc: "Luck, Tony" <tony.luck@intel.com>, Andi Kleen <ak@suse.de>,
"Tolentino, Matthew E" <matthew.e.tolentino@intel.com>,
Joel Schopp <jschopp@austin.ibm.com>,
Dave Hansen <haveblue@us.ibm.com>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org, x86-64 Discuss <discuss@x86-64.org>
Subject: [PATCH: 007/012] Memory hotplug for new nodes v.2.(create sysfs for node (x86-64))
Date: Fri, 17 Feb 2006 13:29:20 +0000 [thread overview]
Message-ID: <20060217213414.4076.Y-GOTO@jp.fujitsu.com> (raw)
This patch is to use arch_register_node() on "x86-64".
x86-64 uses i386's topology.c Howerver, arch_register_node() is
written at include/asm-i386/node.c. x86-64 couldn't use it.
I suppose there is no reason that it must be defined as
inline function. So, I move it to topology.c.
Index: pgdat3/arch/i386/mach-default/topology.c
=================================--- pgdat3.orig/arch/i386/mach-default/topology.c 2005-10-28 12:04:38.000000000 +0900
+++ pgdat3/arch/i386/mach-default/topology.c 2006-02-17 16:17:30.000000000 +0900
@@ -69,6 +69,26 @@ EXPORT_SYMBOL(arch_unregister_cpu);
struct i386_node node_devices[MAX_NUMNODES];
+int arch_register_node(int num)
+{
+ int p_node;
+ struct node *parent = NULL;
+
+ if (!node_online(num))
+ return 0;
+ p_node = parent_node(num);
+
+ if (p_node != num)
+ parent = &node_devices[p_node].node;
+
+ return register_node(&node_devices[num].node, num, parent);
+}
+
+void arch_unregister_node(int num)
+{
+ unregister_node(&node_devices[num].node);
+}
+
static int __init topology_init(void)
{
int i;
Index: pgdat3/include/asm-i386/node.h
=================================--- pgdat3.orig/include/asm-i386/node.h 2005-03-02 16:37:51.000000000 +0900
+++ pgdat3/include/asm-i386/node.h 2006-02-17 16:17:30.000000000 +0900
@@ -11,19 +11,6 @@ struct i386_node {
struct node node;
};
extern struct i386_node node_devices[MAX_NUMNODES];
-
-static inline int arch_register_node(int num){
- int p_node;
- struct node *parent = NULL;
-
- if (!node_online(num))
- return 0;
- p_node = parent_node(num);
-
- if (p_node != num)
- parent = &node_devices[p_node].node;
-
- return register_node(&node_devices[num].node, num, parent);
-}
+extern int arch_register_node(int);
#endif /* _ASM_I386_NODE_H_ */
--
Yasunori Goto
reply other threads:[~2006-02-17 13:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060217213414.4076.Y-GOTO@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=haveblue@us.ibm.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox