From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Kenneth W" Date: Fri, 24 Feb 2006 01:45:14 +0000 Subject: [patch] fix ia64 hugetlb_free_pgd_range Message-Id: <200602240145.k1O1jEg05475@unix-os.sc.intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'David Gibson' , 'Hugh Dickins' , "Luck, Tony" Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org I've looked at hugetlb_free_pgd_range() right side up, right side down, up side up, up side down. And it just doesn't look correct to me at all. In that function, we do address transformation before calling free_pgd_range, so the generic function can traverse to right set of page table page. There is no need to do any range check. Signed-off-by: Ken Chen --- ./arch/ia64/mm/hugetlbpage.c.orig 2006-02-23 18:21:28.202422392 -0800 +++ ./arch/ia64/mm/hugetlbpage.c 2006-02-23 18:26:28.256129654 -0800 @@ -125,9 +125,9 @@ void hugetlb_free_pgd_range(struct mmu_g addr = htlbpage_to_page(addr); end = htlbpage_to_page(end); - if (is_hugepage_only_range(tlb->mm, floor, HPAGE_SIZE)) + if (REGION_NUMBER(floor) = RGN_HPAGE) floor = htlbpage_to_page(floor); - if (is_hugepage_only_range(tlb->mm, ceiling, HPAGE_SIZE)) + if (REGION_NUMBER(ceiling) = RGN_HPAGE) ceiling = htlbpage_to_page(ceiling); free_pgd_range(tlb, addr, end, floor, ceiling);