Re: [PATCH] fix for-loop in sn_hwperf_geoid_to_cnode()

Bjorn Helgaas
2006-03-06T17:35:19Z

On Monday 06 March 2006 09:32, Dean Roe wrote:
> - for_each_node(cnode) {
> + /*
> + * FIXME: replace with cleaner for_each_XXX macro which addresses
> + * both compute and IO nodes once ACPI3.0 is available.
> + */
> + for (cnode = 0; cnode < num_cnodes; cnode++) {

I don't understand this ACPI 3.0 dependency. Can't you just define
for_each_XXX() the way you want it, and fill in the bitmask or whatever
it uses either (a) using ACPI 3.0 data, or (b) some interim hack?

Bjorn