public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Dean Roe <roe@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] fix for-loop in sn_hwperf_geoid_to_cnode()
Date: Mon, 06 Mar 2006 16:32:05 +0000	[thread overview]
Message-ID: <20060306163205.GB23976@sgi.com> (raw)
In-Reply-To: <20060303150312.GA32225@sgi.com>

Patch attempt #2 with a comment added.  Fix a for-loop in
sn_hwperf_geoid_to_cnode().  It needs to loop over num_cnodes to
ensure it can still process TIO nodes in addition to compute nodes
on systems with many nodes.

	Signed-off-by: Dean Roe <roe@sgi.com>


Index: linux-2.6/arch/ia64/sn/kernel/sn2/sn_hwperf.c
=================================--- linux-2.6.orig/arch/ia64/sn/kernel/sn2/sn_hwperf.c
+++ linux-2.6/arch/ia64/sn/kernel/sn2/sn_hwperf.c
@@ -110,7 +110,11 @@
 	if (sn_hwperf_location_to_bpos(location, &rack, &bay, &slot, &slab))
 		return -1;
 
-	for_each_node(cnode) {
+	/*
+	 * FIXME: replace with cleaner for_each_XXX macro which addresses
+	 * both compute and IO nodes once ACPI3.0 is available.
+	 */
+	for (cnode = 0; cnode < num_cnodes; cnode++) {
 		geoid = cnodeid_get_geoid(cnode);
 		module_id = geo_module(geoid);
 		this_rack = MODULE_GET_RACK(module_id);

  parent reply	other threads:[~2006-03-06 16:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-03 15:03 [PATCH] fix for-loop in sn_hwperf_geoid_to_cnode() Dean Roe
2006-03-03 17:01 ` Luck, Tony
2006-03-03 19:49 ` Jack Steiner
2006-03-03 21:52 ` Luck, Tony
2006-03-06 16:28 ` Dean Roe
2006-03-06 16:32 ` Dean Roe [this message]
2006-03-06 17:35 ` Bjorn Helgaas
2006-03-08 22:02 ` Dean Roe
2006-03-08 23:55 ` Bjorn Helgaas
2006-03-09 16:12 ` Robin Holt
2006-03-09 17:57 ` Bjorn Helgaas
2006-03-10 17:57 ` Jack Steiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060306163205.GB23976@sgi.com \
    --to=roe@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox