From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Date: Thu, 09 Mar 2006 12:01:09 +0000 Subject: Re: [PATCH: 013/017](RFC) Memory hotplug for new nodes v.3. Message-Id: <20060309040109.4f9c7d5c.akpm@osdl.org> List-Id: References: <20060308213446.003C.Y-GOTO@jp.fujitsu.com> In-Reply-To: <20060308213446.003C.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yasunori Goto Cc: tony.luck@intel.com, ak@suse.de, jschopp@austin.ibm.com, haveblue@us.ibm.com, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Yasunori Goto wrote: > > Index: pgdat6/include/linux/bootmem.h > =================================> --- pgdat6.orig/include/linux/bootmem.h 2006-03-06 18:25:37.000000000 +0900 > +++ pgdat6/include/linux/bootmem.h 2006-03-06 21:08:05.000000000 +0900 > @@ -88,8 +88,8 @@ static inline void *alloc_remap(int nid, > } > #endif > > -extern unsigned long __initdata nr_kernel_pages; > -extern unsigned long __initdata nr_all_pages; > +extern unsigned long __meminitdata nr_kernel_pages; > +extern unsigned long __meminitdata nr_all_pages; Declaring the section for externs like this isn't very useful really. I don't think there's any way in which the compiler can check it and the linker will look at the definition, not at the declarations. And if we add these, we just need to keep the declarations updated for cosmetic reasons as you've discovered. So I'd recommend you simply remove the __initdata tags here and leave it at that.