Re: [PATCH: 010/017](RFC) Memory hotplug for new nodes v.3. (allocate wait table)

Yasunori Goto
2006-03-10T07:20:37Z

> On Thursday 09 March 2006 13:00, Andrew Morton wrote:
> > Yasunori Goto <y-goto@jp.fujitsu.com> wrote:
> > >
> > > + /* we can use kmalloc() in run time */
> > > + do {
> > > + table_size = zone->wait_table_size
> > > + * sizeof(wait_queue_head_t);
> > > + zone->wait_table = kmalloc(table_size, GFP_ATOMIC);
> >
> > Again, GFP_KERNEL would be better is possible.

Oops.
This was inside of spin_lock in old my patch.
But, it is moved out from spin_lock as a result of refactoring
and I didn't notice that.
Yes. GFP_KERNEL is better.

> >
> > Won't this place the node's wait_table into a different node's memory?
>
> Yes, kmalloc_node would be better.

Kmalloc_node() will not work well at here,
because this patch is to initialize structures for new node -itself-.
It will work after that completion of initalize pgdat and wait_table.

To use new node's memory at here, other consideration will be necessary.
But, I would like to use kmalloc() to simplify my patch at this time.

Thanks.

--
Yasunori Goto