From: "H. J. Lu" <hjl@lucon.org>
To: linux-ia64@vger.kernel.org
Subject: Re: PATCH: Fix gnu-efi-3.0b-041222 for ia32
Date: Fri, 17 Mar 2006 23:31:18 +0000 [thread overview]
Message-ID: <20060317233118.GA22192@lucon.org> (raw)
In-Reply-To: <20060317202301.GA20807@lucon.org>
On Fri, Mar 17, 2006 at 03:15:48PM -0800, James E Wilson wrote:
> On Fri, 2006-03-17 at 13:52, H. J. Lu wrote:
> > *(.gnu.linkonce.t*)
>
> This isn't something you added, but should be fixed just the same. This
> will accidentally cause some thread-local data sections to be merged
> into the text section. The thread-local sections may not have existed
> when this code was written, but they do now. .gnu.linkonce.td.* is used
> for linkonce thread local data, and .gnu.linkonce.tb.* is used for
> linkonce thread local bss.
I guess we never used TLS in EFI applications before. It doesn't
really matter since TLS needs more than the linker script change.
Here is the new patch.
H.J.
---
--- gnu-efi/gnuefi/elf_ia32_efi.lds.ia32 2004-12-22 07:52:28.000000000 -0800
+++ gnu-efi/gnuefi/elf_ia32_efi.lds 2006-03-17 13:48:13.000000000 -0800
@@ -10,6 +10,12 @@ SECTIONS
.text :
{
*(.text)
+ *(.text.*)
+ *(.gnu.linkonce.t.*)
+ }
+ .reloc :
+ {
+ *(.reloc)
}
. = ALIGN(4096);
.data :
@@ -48,12 +54,9 @@ SECTIONS
. = ALIGN(4096);
.dynstr : { *(.dynstr) }
. = ALIGN(4096);
- .ignored.reloc :
+ /DISCARD/ :
{
*(.rel.reloc)
- }
- .ignored :
- {
*(.eh_frame)
}
}
--- gnu-efi/gnuefi/elf_ia64_efi.lds.ia32 2004-12-22 10:18:10.000000000 -0800
+++ gnu-efi/gnuefi/elf_ia64_efi.lds 2006-03-17 15:27:48.000000000 -0800
@@ -10,7 +10,8 @@ SECTIONS
.text :
{
*(.text)
- *(.gnu.linkonce.t*)
+ *(.text.*)
+ *(.gnu.linkonce.t.*)
}
. = ALIGN(4096);
__gp = ALIGN (8) + 0x200000;
@@ -59,13 +60,10 @@ SECTIONS
.dynsym : { *(.dynsym) }
. = ALIGN(4096);
.dynstr : { *(.dynstr) }
- .ignored_reloc :
+ /DISCARD/ :
{
*(.rela.plabel)
*(.rela.reloc)
- }
- /DISCARD/ :
- {
*(.IA_64.unwind*)
*(.IA64.unwind*)
}
next prev parent reply other threads:[~2006-03-17 23:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 20:23 PATCH: Fix gnu-efi-3.0b-041222 for ia32 H. J. Lu
2006-03-17 20:45 ` James E Wilson
2006-03-17 20:53 ` James E Wilson
2006-03-17 21:46 ` H. J. Lu
2006-03-17 21:52 ` H. J. Lu
2006-03-17 21:52 ` Matthew Wilcox
2006-03-17 23:07 ` James E Wilson
2006-03-17 23:15 ` James E Wilson
2006-03-17 23:16 ` Stephane Eranian
2006-03-17 23:31 ` H. J. Lu [this message]
2006-03-17 23:54 ` James E Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060317233118.GA22192@lucon.org \
--to=hjl@lucon.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox