From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dimitri Sivanich Date: Mon, 20 Mar 2006 14:17:47 +0000 Subject: Re: [PATCH] Add SA_PERCPU_IRQ flag support Message-Id: <20060320141747.GA27114@sgi.com> List-Id: References: <20060317003114.GA1735@sgi.com> <20060317152645.52112021.akpm@osdl.org> <20060318014900.65889f69.akpm@osdl.org> In-Reply-To: <20060318014900.65889f69.akpm@osdl.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: torvalds@osdl.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, clameter@sgi.com, jes@sgi.com On Sat, Mar 18, 2006 at 01:49:00AM -0800, Andrew Morton wrote: > Andrew Morton wrote: > > > > +#ifdef ARCH_HAS_IRQ_PER_CPU > > + if (new->flags & SA_PERCPU_IRQ) > > + desc->status |= IRQ_PER_CPU; > > +#endif > > OK, five architectures define ARCH_HAS_IRQ_PER_CPU but only one of them > defines SA_PERCPU_IRQ. Giving up. Could we do the following (at least for now)?: +#if defined(ARCH_HAS_IRQ_PER_CPU) && defined(SA_PERCPU_IRQ) + if (new->flags & SA_PERCPU_IRQ) + desc->status |= IRQ_PER_CPU; +#endif