From: Stephane Eranian <eranian@hpl.hp.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, perfmon@napali.hpl.hp.com,
linux-ia64@vger.kernel.org
Subject: Re: perfmon2 context: thread_struct vs. task_struct?
Date: Thu, 23 Mar 2006 05:41:50 +0000 [thread overview]
Message-ID: <20060323054150.GC26848@frankl.hpl.hp.com> (raw)
In-Reply-To: <20060322183736.4a3bb1c2.akpm@osdl.org>
Andrew,
On Wed, Mar 22, 2006 at 06:37:36PM -0800, Andrew Morton wrote:
> > Would it make sense to move the pointer to the perfmon2
> > context into the task_struct?
>
> I'd say so, yes. Especialy if the struct is the same on all architectures,
> is referred to from non-arch-specific code and is absent if
> CONFIG_PERFMON=n.
>
Yes the structure is the same for all architectures. It looks like
task_struct already has #ifdefs in it. So I could do:
struct task_struct {
....
#ifdef CONFIG_PERFMON
struct pfm_context *pfm_context;
#endif
...
};
--
-Stephane
prev parent reply other threads:[~2006-03-23 5:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-22 23:32 perfmon2 context: thread_struct vs. task_struct? Stephane Eranian
2006-03-23 2:37 ` Andrew Morton
2006-03-23 5:41 ` Stephane Eranian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060323054150.GC26848@frankl.hpl.hp.com \
--to=eranian@hpl.hp.com \
--cc=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perfmon@napali.hpl.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox