From: Andrew Morton <akpm@osdl.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: ak@suse.de, linux-kernel@vger.kernel.org,
davej@codemonkey.org.uk, hpa@zytor.com, alan@lxorguk.ukuu.org.uk,
tony.luck@intel.com, linux-ia64@vger.kernel.org,
discuss@x86-64.org, pazke@donpac.ru, Matt_Domsch@dell.com
Subject: Re: [PATCH] DMI: move dmi_scan.c from arch/i386 to
Date: Thu, 23 Mar 2006 23:51:18 +0000 [thread overview]
Message-ID: <20060323155118.17028026.akpm@osdl.org> (raw)
In-Reply-To: <200603231408.49675.bjorn.helgaas@hp.com>
Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>
> On Thursday 23 March 2006 13:41, Andi Kleen wrote:
> > On Thursday 23 March 2006 21:37, Bjorn Helgaas wrote:
> > > dmi_scan.c is arch-independent and is used by i386, x86_64, and ia64.
> > > Currently all three arches compile it from arch/i386, which means that
> > > ia64 and x86_64 depend on things in arch/i386 that they wouldn't
> > > otherwise care about.
> > >
> > > This is simply "mv arch/i386/kernel/dmi_scan.c drivers/firmware/"
> > > (removing trailing whitespace) and the associated Makefile changes.
> > > All three architectures already set CONFIG_DMI in their top-level
> > > Kconfig files.
> > >
> > > Built and booted on ia64 and i386.
> >
> > This conflicts with at least three patches in my upcomming x86-64 patchkit.
akpm:/usr/src/25> grep -l arch/i386/kernel/dmi_scan.c patches/*.patch
patches/dmi-only-ioremap-stuff-we-actually-need.patch
patches/efi-fixes.patch
patches/efi-keep-physical-table-addresses-in-efi-structure.patch
patches/ia64-use-i386-dmi_scanc.patch
patches/x86_64-mm-dmi-early.patch
patches/x86_64-mm-dmi-year.patch
> > Since it doesn't fix anything I would request that such cleanup patches be
> > delayed.
>
> Sure, that's fine with me. Do you want to let me know when your
> patches are in? Or maybe it would be easier for you to incorporate
> my patch into your patchkit. I just don't know how to tell when
> the cleanup window is open.
>
I'm reluctant to attempt to merge the efi patches until ia64, acpi and
x86_64 have merged. Only ia64 has merged at this time. acpi might need to
be bypassed, dunno.
I'd expect things to be settled down in a couple of weeks. Patches which
move files around are hard.
next parent reply other threads:[~2006-03-23 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200603231337.53657.bjorn.helgaas@hp.com>
[not found] ` <200603232141.09924.ak@suse.de>
[not found] ` <200603231408.49675.bjorn.helgaas@hp.com>
2006-03-23 23:51 ` Andrew Morton [this message]
2006-03-23 23:59 ` [PATCH] DMI: move dmi_scan.c from arch/i386 to drivers/firmware/ Bjorn Helgaas
2006-04-03 21:59 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060323155118.17028026.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Matt_Domsch@dell.com \
--cc=ak@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bjorn.helgaas@hp.com \
--cc=davej@codemonkey.org.uk \
--cc=discuss@x86-64.org \
--cc=hpa@zytor.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@donpac.ru \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox