Re: [5/5] move_pages: 32bit support (i386,x86_64 and ia64)

Jens Axboe
2006-05-24T20:33:17Z

On Wed, May 24 2006, Andrew Morton wrote:
> Christoph Lameter <clameter@sgi.com> wrote:
> >
> > sys_move_pages() support for 32bit (i386 plus ia64 and x86_64 compat layers)
> >
> > Add support for move_pages() on i386 and also add the
> > compat functions necessary to run 32 bit binaries on x86_64 and ia64.
> >
> > Add compat_sys_move_pages to both the x86_64 and the ia64 32bit binary
> > layer. Note that both are not up to date so I added the missing pieces.
> > Not sure if this is done the right way.
> >
> > This probably needs some fixups:
> >
> > 1. What about sys_vmsplice on x86_64?
> >
> > 2. There is a whole range of syscalls missing for ia64 that I basically
> > interpolated from elsewhere.
>
> I dropped the ia64 bits - looks like that's all on death row anyway.
>
> The omission of sys_vmsplice() from the x86 syscall table does appear to
> be, umm, a glaring omission. Jens, what's up?

Uhm yes...

[PATCH] Add vmsplice syscall to x86 table

Signed-off-by: Jens Axboe <axboe@suse.de>

diff --git a/arch/i386/kernel/syscall_table.S b/arch/i386/kernel/syscall_table.S
index f48bef1..af56987 100644
--- a/arch/i386/kernel/syscall_table.S
+++ b/arch/i386/kernel/syscall_table.S
@@ -315,3 +315,4 @@ ENTRY(sys_call_table)
.long sys_splice
.long sys_sync_file_range
.long sys_tee /* 315 */
+ .long sys_vmsplice

--
Jens Axboe