public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Horms <horms@verge.net.au>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] ia64, kexec: shutting down the PCI devices does not seem to be neccessary
Date: Tue, 27 Jun 2006 07:16:02 +0000	[thread overview]
Message-ID: <20060627071600.GA25965@verge.net.au> (raw)

As suggested by Nanhai Zou, it seems that the pci shutdown code in kdump
is not neccessary. I tested the patch on a Tiger2 box, and it seems
to work fine.

Signed-off-by: Horms <horms@verge.net.au>

 arch/ia64/kernel/crash.c |   21 ---------------------
 1 file changed, 21 deletions(-)

db4590a1c287d873fc97d81230579065c4927ac6
diff --git a/arch/ia64/kernel/crash.c b/arch/ia64/kernel/crash.c
index 6623bfc..3f46ee6 100644
--- a/arch/ia64/kernel/crash.c
+++ b/arch/ia64/kernel/crash.c
@@ -22,26 +22,6 @@ #include <linux/elf.h>
 #include <linux/elfcore.h>
 #include <linux/device.h>
 
-static void device_shootdown(void)
-{
-       struct pci_dev *dev;
-       irq_desc_t *desc;
-       u16 pci_command;
-
-       list_for_each_entry(dev, &pci_devices, global_list) {
-               desc = irq_descp(dev->irq);
-               if (!desc->action)
-                       continue;
-               pci_read_config_word(dev, PCI_COMMAND, &pci_command);
-               if (pci_command & PCI_COMMAND_MASTER) {
-                       pci_command &= ~PCI_COMMAND_MASTER;
-                       pci_write_config_word(dev, PCI_COMMAND, pci_command);
-               }
-               disable_irq_nosync(dev->irq);
-               desc->handler->end(dev->irq);
-       }
-}
-
 static Elf64_Word
 *append_elf_note(Elf64_Word *buf, char *name, unsigned type, void *data,
 		size_t data_len)
@@ -123,7 +103,6 @@ machine_crash_shutdown(struct pt_regs *p
 		ia64_eoi();
 	}
 	crash_save_this_cpu();
-	device_shootdown();
 #ifdef CONFIG_SMP
 	smp_send_stop();
 #endif

             reply	other threads:[~2006-06-27  7:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-27  7:16 Horms [this message]
2006-06-27  7:25 ` [PATCH] ia64, kexec: shutting down the PCI devices does not seem to be neccessary Horms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060627071600.GA25965@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox