From mboxrd@z Thu Jan  1 00:00:00 1970
From: Horms <horms@verge.net.au>
Date: Tue, 18 Jul 2006 19:15:00 +0000
Subject: Re: [PATCH] panic_on_oops: remove ssleep()
Message-Id: <20060718191456.GF20141@verge.net.au>
List-Id: <linux-ia64.vger.kernel.org>
References: <200607172126_MC3-1-C544-E35A@compuserve.com>
In-Reply-To: <200607172126_MC3-1-C544-E35A@compuserve.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>, Chris Zankel <chris@zankel.net>, Russell King <rmk@arm.linux.org.uk>, Tony Luck <tony.luck@intel.com>, Paul Mackerras <paulus@samba.org>, Anton Blanchard <anton@samba.org>, Andi Kleen <ak@suse.de>, Andrew Morton <akpm@osdl.org>, linux-ia64 <linux-ia64@vger.kernel.org>, discuss@x86-64.org, linux-kernel <linux-kernel@vger.kernel.org>

On Mon, Jul 17, 2006 at 09:22:17PM -0400, Chuck Ebbert wrote:
> In-Reply-To: <31687.FP.7244@verge.net.au>
> 
> On Mon, 17 Jul 2006 12:17:20 -0400, Horms wrote:
> 
> > This patch is part of an effort to unify the panic_on_oops behaviour
> > across all architectures that implement it.
> > 
> > It was pointed out to me by Andi Kleen that if an oops has occured
> > in interrupt context, then calling sleep() in the oops path will only cause
> > a panic, and that it would be really better for it not to be in the path at
> > all. 
> 
> i386 already checks in_interrupt() and panics immediately:

Very good point. I guess that needs to be moved to after
panic_on_oops() if the change that Andi suggests works out.

-- 
Horms                                           
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/