From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Fri, 28 Jul 2006 14:50:22 +0000 Subject: Re: [PATCH] add platform check to a couple sn2-only drivers Message-Id: <20060728145022.GA8103@infradead.org> List-Id: References: <20060728143626.GD27686@sgi.com> In-Reply-To: <20060728143626.GD27686@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ia64@vger.kernel.org On Fri, Jul 28, 2006 at 09:36:26AM -0500, Greg Edwards wrote: > - nasid_t event_nasid = ia64_sn_get_console_nasid(); > + nasid_t event_nasid; > + > + if (!ia64_platform_is("sn2")) > + return -ENODEV; > + > + event_nasid = ia64_sn_get_console_nasid(); this one is okay and required. > static int __devinit > ioc4_init(void) > { > + if (!ia64_platform_is("sn2")) > + return -ENODEV; > + this one not. The pci id matching will take care of things.