Re: [RFC][PATCH 10/10] convert the "easy" architectures to generic PAGE_SIZE

Paul Mundt
2006-08-30T10:05:18Z

On Tue, Aug 29, 2006 at 01:19:41PM -0700, Dave Hansen wrote:
> diff -puN include/asm-sh/page.h~arch-generic-PAGE_SIZE-give-every-arch-PAGE_SHIFT include/asm-sh/page.h
> --- threadalloc/include/asm-sh/page.h~arch-generic-PAGE_SIZE-give-every-arch-PAGE_SHIFT 2006-08-29 13:14:48.000000000 -0700
> +++ threadalloc-dave/include/asm-sh/page.h 2006-08-29 13:14:58.000000000 -0700
> @@ -13,12 +13,7 @@
> [ P4 control ] 0xE0000000
> */
>
> -
> -/* PAGE_SHIFT determines the page size */
> -#define PAGE_SHIFT 12
> -#define PAGE_SIZE (1UL << PAGE_SHIFT)
> -#define PAGE_MASK (~(PAGE_SIZE-1))
> -#define PTE_MASK PAGE_MASK
> +#include <asm-generic/page.h>
>
Overzealous deletion? Please leave PTE_MASK there, we use it for
_PAGE_CHG_MASK in pgtable.h.