Re: [RFC][PATCH 4/9] ia64 generic PAGE_SIZE

Dave Hansen
2006-08-31T17:38:30Z

On Wed, 2006-08-30 at 16:57 -0700, Christoph Lameter wrote:
> On Wed, 30 Aug 2006, Dave Hansen wrote:
>
> > @@ -64,11 +64,11 @@
> > * Base-2 logarithm of number of pages to allocate per task structure
> > * (including register backing store and memory stack):
> > */
> > -#if defined(CONFIG_IA64_PAGE_SIZE_4KB)
> > +#if defined(CONFIG_PAGE_SIZE_4KB)
> > # define KERNEL_STACK_SIZE_ORDER 3
> > -#elif defined(CONFIG_IA64_PAGE_SIZE_8KB)
> > +#elif defined(CONFIG_PAGE_SIZE_8KB)
> > # define KERNEL_STACK_SIZE_ORDER 2
> > -#elif defined(CONFIG_IA64_PAGE_SIZE_16KB)
> > +#elif defined(CONFIG_PAGE_SIZE_16KB)
> > # define KERNEL_STACK_SIZE_ORDER 1
> > #else
> > # define KERNEL_STACK_SIZE_ORDER 0
>
> Could we replace these lines with
>
> #define KERNEL_STACK_SIZE_ORDER (max(0, 15 - PAGE_SHIFT))

My next series will be to clean up stack size handling. Do you mind if
it waits until then?

-- Dave