Re: [PATCH 2/6] Introduce CONFIG_ZONE_DMA

Paul Mundt
2006-09-18T22:45:48Z

On Mon, Sep 18, 2006 at 10:33:00AM -0700, Christoph Lameter wrote:
> sh64 has the same strange code as parisc:
>
> config GENERIC_ISA_DMA
> bool
>
> You do not have ISA_DMA so I should drop these lines?
>
It doesn't really matter, this notation basically keeps it disabled
anyways (you'll note the absence of it from the defconfigs).

On Mon, Sep 18, 2006 at 11:36:55AM -0700, Christoph Lameter wrote:
> Index: linux-2.6.18-rc6-mm2/arch/sh/mm/init.c
> =================================> --- linux-2.6.18-rc6-mm2.orig/arch/sh/mm/init.c 2006-09-18 12:54:04.733274009 -0500
> +++ linux-2.6.18-rc6-mm2/arch/sh/mm/init.c 2006-09-18 12:58:58.563038661 -0500
> @@ -156,7 +156,6 @@ void __init paging_init(void)
> * Setup some defaults for the zone sizes.. these should be safe
> * regardless of distcontiguous memory or MMU settings.
> */
> - zones_size[ZONE_DMA] = 0 >> PAGE_SHIFT;
> zones_size[ZONE_NORMAL] = __MEMORY_SIZE >> PAGE_SHIFT;
> #ifdef CONFIG_HIGHMEM
> zones_size[ZONE_HIGHMEM] = 0 >> PAGE_SHIFT;

You've missed the other ZONE_DMA references, if you scroll a bit further
down that's where we fill in ZONE_DMA, this is simply the default zone
layout that we rely on for nommu.

sh64 part looks fine.