From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Date: Tue, 26 Sep 2006 15:50:41 +0000 Subject: Re: [PATCH 2.6.18] IA64: Add pci_fixup_video into IA64 kernel for embedded VGA Message-Id: <200609260850.41609.jesse.barnes@intel.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: eiichiro.oiwa.nm@hitachi.com Cc: akpm@osdl.org, tony.luck@intel.com, greg@kroah.com, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org On Tuesday, September 26, 2006 12:42 am, eiichiro.oiwa.nm@hitachi.com wrote: > To be compatible with Xorg's handling of PCI, we need pci_fixup_video on > IA64 platform like x86 platform. There are also machines, which have VGA > embedded into main board, among IA64 platform. Embedded VGA generally > don't have PCI ROM, and there are VGA ROM image in System BIOS. > Therefore, these machines need pci_fixup_video for the sysfs rom. > pci_fixup_video already exists in x86 Linux kernel. However since this > function doesn't exist in IA64 kernel, we could not run X server on IA64 > box has embedded-VGA. > > I tested pci_fixup_video on IA64 box has embedded-VGA. I confirmed we > can read VGA BIOS from the sysfs rom regardless of embedded-VGA. Looks good, Eiichiro, thanks for posting this. > +#include > +#include > +#include > +#include For this version, I don't think you need delay.h or dmi.h. And like Bjorn mentioned, this could probably be turned into generic code in drivers/pci so we don't have too much duplication with x86 (and like I mentioned, x86_64 could probably use this too). Jesse