public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: linux-ia64@vger.kernel.org
Subject: Re: kexec/kdump and the ia64 test tree
Date: Mon, 02 Oct 2006 17:35:01 +0000	[thread overview]
Message-ID: <20061002173501.GA27693@intel.com> (raw)
In-Reply-To: <200609292146.k8TLkNex005603@agluck-lia64.sc.intel.com>

> overall that plan seems fine to me - though I would have preferred
> a more incremental approach.

There are conflicting opinions on this on LKML ... some people believe
that it is better that the Linux change log represent history as it
should have been ... i.e. clean away all the goofs and mis-steps in
the sub-trees and send Linus the one true patch (or series of patches)
that do exactly what is wanted.  For the case of the white-space cleanup
part of the kexec/kdump patches, I can solidly get behind this opinion:
I can see no benefit to keeping separate patches that first mess-up
the whitespace, and then fix it.

On the other hand ... when there are real code changes involved, there
is definite benefit to preserving the dead-end development paths that
were abandoned (so that future debugging/development efforts at least
have the option to learn from our mistakes).  The removal of
ioc_iova_disable() almost falls into this category ... except that
we have already dropped the places where it was called, so if we
preserve it now, it would just be as the addition and immediate
removal of some dead code ... which looks to have less historical
value.

>                                I will spend some time today checking
> over your patch and see if I can spot any insanity.

Thanks for taking the time to do this.

> On a related note, does/did your ia64-test branch have anything
> of significance in it other than kexec/kdump?

There were a couple of other patches in "test" that I pulled over
to release and sent to Linus.  So kexec is all that is in there right
now.

-Tony

      parent reply	other threads:[~2006-10-02 17:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-29 21:46 kexec/kdump and the ia64 test tree Tony Luck
2006-09-29 22:26 ` Andrew Morton
2006-10-02  1:11 ` Horms
2006-10-02  4:09 ` Horms
2006-10-02 17:35 ` Luck, Tony [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061002173501.GA27693@intel.com \
    --to=tony.luck@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox